Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert change to system transaction gas data #12848

Merged
merged 1 commit into from
Jul 5, 2023
Merged

Conversation

mystenmark
Copy link
Contributor

this change (from #12676) broke compatibility since it was not gated - if the change was necessary we will have to put in a feature flag

@vercel
Copy link

vercel bot commented Jul 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

6 Ignored Deployments
Name Status Preview Updated (UTC)
explorer ⬜️ Ignored (Inspect) Jul 5, 2023 9:25pm
explorer-storybook ⬜️ Ignored (Inspect) Jul 5, 2023 9:25pm
multisig-toolkit ⬜️ Ignored (Inspect) Jul 5, 2023 9:25pm
sui-kiosk ⬜️ Ignored (Inspect) Jul 5, 2023 9:25pm
sui-wallet-kit ⬜️ Ignored (Inspect) Jul 5, 2023 9:25pm
wallet-adapter ⬜️ Ignored (Inspect) Jul 5, 2023 9:25pm

@dariorussi
Copy link
Contributor

it was not gated as I thought (and verified by sync'ing the change on mainnet and testnet) that it was not causing any change in behavior or effects.
I am curious to understand what I did not take into account, maybe some error condition in some system transaction that I never run into?
In any case accepting as it should not change what was there and double checking things will behave the same way

@mystenmark
Copy link
Contributor Author

it was not gated as I thought (and verified by sync'ing the change on mainnet and testnet) that it was not causing any change in behavior or effects.
I am curious to understand what I did not take into account, maybe some error condition in some system transaction that I never run into?
In any case accepting as it should not change what was there and double checking things will behave the same way

@dariorussi it changes the digest of any system TX, which in turn causes checkpoint digests to diverge

@mystenmark mystenmark merged commit d0c78f3 into main Jul 5, 2023
@mystenmark mystenmark deleted the mlogan-fix-system-tx branch July 5, 2023 22:36
longbowlu pushed a commit that referenced this pull request Jul 6, 2023
this change (from #12676) broke compatibility since it was not gated -
if the change was necessary we will have to put in a feature flag
ebmifa pushed a commit that referenced this pull request Jul 12, 2023
this change (from #12676) broke compatibility since it was not gated -
if the change was necessary we will have to put in a feature flag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants